chore: gut vibecoded miden-rpc-proxy lib (supplanted by miden-agglayer)#4
chore: gut vibecoded miden-rpc-proxy lib (supplanted by miden-agglayer)#4revitteth wants to merge 2 commits intouse-miden-agglayerfrom
Conversation
The Kurtosis package (kurtosis/miden-cdk/, see commit e7b4660) already deploys gateway-fm/miden-agglayer as the production miden-proxy service. The lib + main + bin code in src/ was the prior vibecoded implementation and has been dead code since the supplant. Worse, it didn't compile against current miden-client (API drift across `Felt::as_int`, `OutputNote::Full`, `create_agglayer_faucet` signature, etc.) so `cargo check` was failing on this branch. What's removed: - src/main.rs and the entire `miden-rpc-proxy` binary. - src/{address_mapper,agglayer_faucet,asset_mapping,block_state, claim_tracker,client,config,decode,error,log_synthesis,receipt, storage,types}.rs — the vibecoded modules. Equivalents (in some cases improved) live in gateway-fm/miden-agglayer. - src/bin/{verify_notes,claim_note}.rs — operator helpers that also drifted off miden-client v0.14.4 (use deprecated `Felt::as_int`). If we want them back, port them against the current API. - examples/gen_signed_tx.rs — same drift class. What's kept: - tests/phase{1,2,3}.rs + tests/common — miden-client integration tests. Independent of the proxy. Currently have their own API drift vs v0.14.4 (separate fix); not blocking the supplant. - kurtosis/miden-cdk/ — Starlark package that deploys miden-agglayer + aggkit + bridge-service + agglayer + miden-node. - scripts/ — operator/test harnesses that drive the kurtosis stack. Cargo.toml dropped to a thin shell: - Pin miden-client to `tag = "v0.14.4"` (was `branch = "agglayer-integration-tests"`) to match gateway-fm/miden-agglayer's pin. - Loose carets on miden-protocol/standards/tx so cargo can resolve the exact subversion v0.14.4 transitively requires. - Drop jsonrpsee/tower/alloy/etc — none of the surviving code uses them. Follow-up (separate work): - Port tests/phase{1,2,3}.rs to miden-client v0.14.4 API (`build_consume_notes` now takes Vec<Note>, etc.). - Run scripts/e2e-kurtosis.sh against the patched miden-agglayer:rd-862 image to validate the full e2e flow. - Once gateway-fm/miden-agglayer's RD-862 fix and agglayer/aggkit's upstream PR land, swap the kurtosis package's image refs to public tagged releases. Refs: - gateway-fm/miden-agglayer#37 - agglayer/aggkit#1597 - Linear RD-862 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…faucet_registry migration End-to-end validation of the RD-862 fix on the kurtosis stack required three small alignments: 1. `params.yaml`: set `aggkit_image: "miden-agglayer/aggkit:rd-862"` so the kurtosis-cdk parser threads our locally-built patched aggkit through to `bridge_service.star::_deploy_aggkit`. Without this the default `ghcr.io/agglayer/aggkit:0.9.0-rc2` was picked up and the `UseUpdateExitRoot` config was silently ignored. 2. `bridge_service.star`: add `UseUpdateExitRoot = true` to the `[AggOracle.EVMSender]` section of the inlined aggkit config template. This is the flag the patched aggkit reads to switch `EVMChainGERSender` from `direct_injection` to `direct_update_exit_root` mode. 3. `miden_services.star`: append `migrations/002_faucet_registry.sql` (CREATE TABLE faucet_registry + idx_faucet_origin) to the inlined migration SQL. Previously only `001_initial.sql` was inlined, so miden-proxy startup failed with `db error ERROR: relation "faucet_registry" does not exist`. Added a comment marking the inline as a snapshot and pointing at the long-term fix (upload the migrations dir as a files-artifact). Validation: kurtosis enclave deployed cleanly with all services RUNNING. aggkit logs show `EVMChainGERSender initialized in direct_update_exit_root mode` followed by `update-exit-root GER transaction submitted` — i.e. the two-root calldata path. miden-proxy logs show 0 `L1 exit roots don't match injected GER` warnings (orphan count = 0). The L1→Miden test deposit completes; both injected GERs committed without decomposition. Refs: - gateway-fm/miden-agglayer#37 - agglayer/aggkit#1597 - Linear RD-862 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@mandrigin — careful review appreciated when you're around. Two related changes here:
Validated: |
Summary
Kurtosis already deploys `gateway-fm/miden-agglayer` as the miden-proxy service (commit `e7b4660`). The lib + main + bins in `src/` were the prior vibecoded implementation, dead code since the supplant, and stopped compiling against current `miden-client` (API drift on `Felt::as_int`, `OutputNote::Full`, `create_agglayer_faucet` signature, etc.).
This PR removes the dead code so the repo can build cleanly and reflects what's actually deployed.
Removed
Kept
Cargo.toml realignment
Validation
Follow-up
🤖 Generated with Claude Code