Skip to content

fix: replace WriteString(fmt.Sprintf()) with fmt.Fprintf #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghaskins merged 1 commit into from
Mar 14, 2026
Merged

fix: replace WriteString(fmt.Sprintf()) with fmt.Fprintf #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/policydomain/validation/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,15 @@ func (ve *Errors) Error() string {
}

var sb strings.Builder
sb.WriteString(fmt.Sprintf("validation failed with %d errors:\n", len(ve.Errors)))
fmt.Fprintf(&sb, "validation failed with %d errors:\n", len(ve.Errors))

for i, err := range ve.Errors {
// Include type information in the error output
typeInfo := ""
if err.Type != "" {
typeInfo = fmt.Sprintf("[%s] ", err.Type)
}
sb.WriteString(fmt.Sprintf(" %d. %s%s\n", i+1, typeInfo, err.Error()))
fmt.Fprintf(&sb, " %d. %s%s\n", i+1, typeInfo, err.Error())
}

return sb.String()
Expand Down Expand Up @@ -163,16 +163,16 @@ func (ve *Errors) Summary() string {
byType := ve.ErrorsByType()

var sb strings.Builder
sb.WriteString(fmt.Sprintf("Validation Summary: %d errors found\n", len(ve.Errors)))
fmt.Fprintf(&sb, "Validation Summary: %d errors found\n", len(ve.Errors))

sb.WriteString("\nBy Domain:\n")
for domain, errors := range byDomain {
sb.WriteString(fmt.Sprintf(" %s: %d errors\n", domain, len(errors)))
fmt.Fprintf(&sb, " %s: %d errors\n", domain, len(errors))
}

sb.WriteString("\nBy Type:\n")
for errType, errors := range byType {
sb.WriteString(fmt.Sprintf(" %s: %d errors\n", errType, len(errors)))
fmt.Fprintf(&sb, " %s: %d errors\n", errType, len(errors))
}

return sb.String()
Expand Down
Loading