fix: correct changelog version from 2.35.3 to 2.35.0 and add 2.35.1 entry#114
Merged
Conversation
mangs
reviewed
May 20, 2026
|
|
||
| interface ServerConfiguration extends Pick<ServeOptions, 'error' | 'hostname' | 'port'> { | ||
| interface ServerConfiguration | ||
| extends Partial<Pick<Serve.Options<undefined>, 'error' | 'hostname' | 'port'>> { |
Owner
There was a problem hiding this comment.
Running the locally looks like this can be simplified a bit
Suggested change
| extends Partial<Pick<Serve.Options<undefined>, 'error' | 'hostname' | 'port'>> { | |
| extends Pick<Serve.Options<undefined>, 'error' | 'hostname' | 'port'> { |
mangs
approved these changes
May 28, 2026
mangs
left a comment
mangs
left a comment
Owner
There was a problem hiding this comment.
Woo thanks for making this happen!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Changes Included