Skip to content

Fix deprecation warning for Aws::S3::Object#upload_file by replacing with Aws::S3::TransferManager#upload_file #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremiahlukus wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix deprecation warning for Aws::S3::Object#upload_file by replacing with Aws::S3::TransferManager#upload_file #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d5eb7a
fix upload_file deprecated warning
jeremiahlukus Sep 16, 2025
6325daa
up version
jeremiahlukus Sep 16, 2025
c3e3434
update change log
jeremiahlukus Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## [0.8.1] (2025-09-16)

### Bug Fixes

* Fix deprecation warning for Aws::S3::Object#upload_file by replacing with Aws::S3::TransferManager#upload_file

## [0.8.0](https://github.com/manheim/eb_deployer/compare/v0.7.0...v0.8.0) (2023-10-17)


Expand Down
7 changes: 5 additions & 2 deletions lib/eb_deployer/aws_driver/s3_driver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,18 @@ def object_length(bucket_name, obj_name)
end

def upload_file(bucket_name, obj_name, file)
o = obj(bucket_name, obj_name)
o.upload_file(file)
transfer_manager.upload_file(file, bucket_name, obj_name)
end

private
def s3
Aws::S3::Resource.new(client: Aws::S3::Client.new)
end

def transfer_manager
@transfer_manager ||= Aws::S3::TransferManager.new(client: Aws::S3::Client.new)
end

def obj(bucket_name, obj_name)
s3.bucket(bucket_name).object(obj_name)
end
Expand Down
2 changes: 1 addition & 1 deletion lib/eb_deployer/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module EbDeployer
VERSION = "0.8.0"
VERSION = "0.8.1"
Copy link

@codezninja codezninja Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this would be patch change. I believe this should be a minor change and probably tied to a min version of aws-sdk and ruby now

Copy link
Author

@jeremiahlukus jeremiahlukus Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct. Im going to do a bit of testing tomorrow, and push again after running some tests.

end