Conversation
basic scaffolding for a new tui old tui has been moved to a folder called and has been gitignored for cleanliness
- new sqlc func for get all collections - some bug fixes in the list config - changed existing list collections func to not use pagination - added a generic to list config for crud - defined the crud struct - added a crud struct to the collections view which is supplied to the list component
- bug fixes in main model - made it so that colors are not exposed, only styles are - updated the update func for options provider to forward messages to the list component - set up the list crud op and the item mapper for collections view - changed generics in the list config so it makes more sense - updated the footer func for collections
…returns endpoint counts
- created a messages package for circulating messages - removed crud from the config and gave it access to only the list func - added generics to the OptionsProvider - styled the input and added functionality to add collections - created and input config - added some styling attributes - extracted some colors from the styles and made vars out of them
…eralise into a component)
- added a new db query for listing all endpoints by collection (non paginated) - created a new manager function for fetching these - renamed the old function responsible for listing eps - changed the tests for the old function to make sure the still work - slightly modified the choose items message to make it work better when sent by different views - more work on the ep view to make it display eps - the addition of a set state function to the interface to set the state of certain views
- Remove EndpointCount field from core CollectionEntity - Use simple GetCollections query without JOIN - Add GetEndpointCountsByCollections query - Update itemMapper to fetch counts only for display
- Add NavigateToView message type - Views emit navigation messages, app handles routing
ItemAdded now uses commands, improving internal consistency and laying the groundwork for better error handling/UI updates.
- Reflects architectural improvements and backend cleanup - Message-driven navigation and CRUD operations - Performance improvements with efficient batch queries - Enhanced error handling prototype
It won't work if you're on "Collections" view because there's no going back from there. I've kept this separate from `Ctrl-c` quit as to have different key-stroke flows for going back/forth vs quitting the app.
This reverts commit b0311e1.
maniac-en
requested changes
Aug 23, 2025
Owner
maniac-en
left a comment
There was a problem hiding this comment.
- Please follow this pattern of test error output format:
Expected <this>, got <this> - Please add a reverse-check within the same test that empty URL is indeed preserved. Currently, you're only checking is error returned is
nilor not!
My suggestion:
endpoint, err := manager.CreateEndpoint(ctx, data)
if err != nil {
t.Errorf("Expected empty URL to be allowed, got error: %v", err)
}
if endpoint.URL != "" {
t.Errorf("Expected empty URL to be preserved, got %s", endpoint.URL)
}v0.1.0.alpha.2v0.1.0-alpha.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete TUI rework:
Backend and architecture improvements:
UI/UX redesign: