Skip to content

fix: show loading indicator during chat submitted state#3

Open
vraj00222 wants to merge 1 commit intomaniculehq:mainfrom
vraj00222:fix/chat-loading-indicator
Open

fix: show loading indicator during chat submitted state#3
vraj00222 wants to merge 1 commit intomaniculehq:mainfrom
vraj00222:fix/chat-loading-indicator

Conversation

@vraj00222
Copy link
Copy Markdown

@vraj00222 vraj00222 commented Mar 15, 2026

ChatLoading only rendered during "streaming" status, leaving a dead gap between sending a message and receiving the first token. This was especially noticeable on slower endpoints (e.g. hosted Haiku).

before
Screenshot 2026-03-14 at 11 19 08 PM
after
Screenshot 2026-03-14 at 11 19 42 PM

  • Show bouncing dot indicator during "submitted" state, hide once streaming begins
  • Replace spinner + text with a minimal animated typing indicator that follows the palette's foreground color
  • Add bcmdk-bounce keyframe to library styles
  • Remove unused LoaderIcon import

Summary by CodeRabbit

  • Style & UI Updates
    • Loading indicator redesigned with animated dots animation
    • Loading state timing adjusted during message submission
    • New bounce animation effect added to UI

ChatLoading only rendered during "streaming" status, leaving a dead gap
between sending a message and receiving the first token. This was
especially noticeable on slower endpoints (e.g. hosted Haiku).

- Show bouncing dot indicator during "submitted" state, hide once
  streaming begins
- Replace spinner + text with a minimal animated typing indicator
  that follows the palette's foreground color
- Add bcmdk-bounce keyframe to library styles
- Remove unused LoaderIcon import

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 15, 2026

@vraj00222 is attempting to deploy a commit to the Shreyans Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 15, 2026

📝 Walkthrough

Walkthrough

Updates the chat loading indicator by replacing an icon-based loader with animated dots, adjusts the display timing to render during "submitted" status instead of "streaming", and introduces a bounce keyframe animation to support the new visual design.

Changes

Cohort / File(s) Summary
Chat Loading Component
packages/better-cmdk/components/ui/chat.tsx, packages/better-cmdk/styles/index.css
Replaces LoaderIcon with three animated dot spans and adds a visually-hidden loading message for accessibility. Introduces a new bcmdk-bounce keyframes animation with vertical translation and opacity variation at different timing stages.
Command Menu Logic
packages/better-cmdk/components/ui/command-menu.tsx
Changes ChatLoading rendering condition from status === "streaming" to status === "submitted", altering when the loading indicator appears during message rendering.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

Three dots that bounce and dance with grace, 🐰✨
No icons here to clutter the space,
Accessibility whispers in the hidden text,
A smoother flow—what comes up next?
Submitted status takes the stage so bright! 🎪

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: showing a loading indicator during the chat submitted state, which is the primary objective of this PR.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant