Skip to content

Creating new connection for every request to TSDB endpoint #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boopathi wants to merge 2 commits into
base: opentsdb_scratch
Choose a base branch
from
Open

Creating new connection for every request to TSDB endpoint #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32ef38b
Removing self.conn in OpenTSDB Finder. It is recommended that for eve…
boopathi Aug 20, 2013
7935ff1
Index Error while rendering. This happens when the requested for lowe…
boopathi Aug 21, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions webapp/graphite/finders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ class OpenTSDBFinder:
def __init__(self, host, port):
self.host = host
self.port = port
self.conn = httplib.HTTPConnection(self.host, self.port)

def find_nodes(self, query):
# if (query.drilldown == True):
Expand Down Expand Up @@ -262,14 +261,21 @@ def drill_recursive(self, patterns, index, current_branch):
log.debug("Skipping node [" + patterns[index] + "] on node [" + node.name + "] in branch [" + str(current_branch) + "]")

def fetch_branch(self, query):
self.conn.request("GET", "/api/tree/branch?branch=" + query.pattern)
resp = self.conn.getresponse()
conn = httplib.HTTPConnection(self.host, self.port)
conn.request("GET", "/api/tree/branch?branch=" + query.pattern)
resp = conn.getresponse()
#Make sure you grab the data immediately. resp.read() second time gives an empty string
data = resp.read()
log.debug("API request has returned")
if resp.status != 200:
log.warn("Could not find a branch for [" + query.pattern + "]. Status: " + str(resp.status))
else:
log.debug("Positive response from OpenTSDB for the branch at [" + query.pattern + "]")
json_data = json.loads(resp.read())
#Warn if data is empty. json.loads will throw the error for you
if not data:
log.warn("The JSON returned for the query [" + query.pattern +"] is empty");
else:
log.debug("Positive response from OpenTSDB for the branch at [" + query.pattern + "]")
json_data = json.loads(data)

if (json_data['branches'] and (json_data['branches']) > 0):
for i in xrange(len(json_data['branches'])):
Expand Down
2 changes: 1 addition & 1 deletion webapp/graphite/readers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def fetch(self, startTime, endTime):
log.debug("Key [" + str(key) + "] was greater than end time [" + str(int(endTime)) + "]")
break

valueList[counter] = json_data[0]['dps'][key]
valueList[counter-1] = json_data[0]['dps'][key]
counter += 1
log.debug("Retrieved [" + str(counter) + "] datapoints")

Expand Down