🔧 Fix Code Quality: Unguarded file read causes FileNotFoundException if dependency report is absent#1
Open
manos-saratsis wants to merge 1 commit into
Conversation
…ion if dependency report is absent File: Dangerfile.df.kts In Dangerfile.df.kts, updatesFile.readLines() is called without first checking updatesFile.exists(). If the dependencyUpdates Gradle task has not been executed prior to the Danger step, the file will not exist and a FileNotFoundException will be thrown, crashing the Danger check entirely and producing a misleading CI failure. Generated by OrchestrAI Code Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Fixed
Type: Code Quality
File:
Dangerfile.df.ktsLine: 30
Description
In Dangerfile.df.kts, updatesFile.readLines() is called without first checking updatesFile.exists(). If the dependencyUpdates Gradle task has not been executed prior to the Danger step, the file will not exist and a FileNotFoundException will be thrown, crashing the Danger check entirely and producing a misleading CI failure.
Suggested Fix
Guard the read with an existence check: if (updatesFile.exists()) { val lines = updatesFile.readLines() /* process lines */ } else { warn("Dependency updates report not found.") }
Changes Made
Generated by OrchestrAI Software Engineer