🔧 Fix Code Quality: window.location.search used instead of router's useSearch()#2
Open
manos-saratsis wants to merge 1 commit into
Open
🔧 Fix Code Quality: window.location.search used instead of router's useSearch()#2manos-saratsis wants to merge 1 commit into
manos-saratsis wants to merge 1 commit into
Conversation
…'s useSearch() File: frontend/src/routes/reset-password.tsx Direct access to window.location couples the component to the browser environment, bypasses the router's state, and makes unit testing impossible without jsdom mocks. Generated by OrchestrAI Code Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Fixed
Type: Code Quality
File:
frontend/src/routes/reset-password.tsxLine: 46
Description
Direct access to window.location couples the component to the browser environment, bypasses the router's state, and makes unit testing impossible without jsdom mocks.
Suggested Fix
Add token to the route's search schema via
validateSearchand access it withRoute.useSearch(), consistent with howadmin.tsxhandles search params.Changes Made
Generated by OrchestrAI Software Engineer