🔧 Fix Code Quality: currentUser read from queryClient cache directly instead of via hook#3
Open
manos-saratsis wants to merge 1 commit into
Open
Conversation
…tly instead of via hook File: frontend/src/routes/_layout/admin.tsx Using `queryClient.getQueryData<UserPublic>(['currentUser'])` is fragile — if the cache key changes or the data hasn't been fetched yet, this silently returns undefined. There is no re-render trigger if the data loads after mount. Generated by OrchestrAI Code Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Fixed
Type: Code Quality
File:
frontend/src/routes/_layout/admin.tsxLine: 37
Description
Using
queryClient.getQueryData<UserPublic>(['currentUser'])is fragile — if the cache key changes or the data hasn't been fetched yet, this silently returns undefined. There is no re-render trigger if the data loads after mount.Suggested Fix
Use
useQuery({ queryKey: ['currentUser'], ... })with a proper queryFn, or create auseCurrentUser()hook that wraps useQuery, consistent with the rest of the app's data-fetching pattern.Changes Made
Generated by OrchestrAI Software Engineer