fix(http): update error message for unsupported queries#3989
Open
donhardman wants to merge 1 commit intomasterfrom
Open
fix(http): update error message for unsupported queries#3989donhardman wants to merge 1 commit intomasterfrom
donhardman wants to merge 1 commit intomasterfrom
Conversation
Collaborator
|
@donhardman Since we're changing the error message and some clients might depend on it, we should treat this as a breaking change. When you squash the commits, please make sure the message clearly states that it's a breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error "only SELECT statements are supported" is a bit confusing and does not recognize sysvar SELECTs but still does not support them. So the idea is to improve the message to make it clear.