Add DeleteFiles table update API#13
Open
manuzhang wants to merge 3 commits into
Open
Conversation
Owner
Author
Summary
Testing
|
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
TableUpdate::Kind::kDeleteFilesenum and atable::DeleteFilesclass with astd::vector<std::string>files()payload insrc/iceberg/table_update.h.DeleteFilesmethods insrc/iceberg/table_update.ccwhereApplyTo/GenerateRequirementsare no-ops and provideEqualsandCloneimplementations."delete-files"with thefilesfield insrc/iceberg/json_serde.ccand add a unit test covering theDeleteFilesJSON roundtrip insrc/iceberg/test/json_serde_test.cc.Testing
JsonInternalTest.TableUpdateDeleteFilesexercisingToJsonandTableUpdateFromJsonforDeleteFileswhich is included insrc/iceberg/test/json_serde_test.cc(test not executed here).cmake -S . -B build -DBUILD_TESTING=ONto run tests but configuration failed due to blocked external dependency downloads (HTTP 403 via proxy), so test suite was not run in this environment.Codex Task