Skip to content

feat: support Iceberg v3 unknown type#14

Open
manuzhang wants to merge 1 commit into
mainfrom
codex/support-unknown-v3-type
Open

feat: support Iceberg v3 unknown type#14
manuzhang wants to merge 1 commit into
mainfrom
codex/support-unknown-v3-type

Conversation

@manuzhang
Copy link
Copy Markdown
Owner

@manuzhang manuzhang commented May 28, 2026

No description provided.

@manuzhang
Copy link
Copy Markdown
Owner Author

manuzhang commented May 28, 2026

@codex rebase on main and address review comments in apache#662

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented May 28, 2026

Summary

  • I inspected the local branch (work) and confirmed it is already at commit d2a34b53b258d927aac167001952d14470a1b3d2, which matches the PR head SHA in your provided <PR_INFO>. I did not make any code changes, so there was nothing to commit and no follow-up PR was created.
  • I attempted to rebase onto main from https://github.com/apache/iceberg-cpp.git, but the environment cannot reach GitHub over HTTPS (CONNECT tunnel 403), so the rebase could not be performed from this runner.

Testing

  • ✅ git status --short && git branch --show-current && git remote -v
  • ✅ git log --oneline -n 5; git show --no-patch --pretty=fuller HEAD
  • ❌ git fetch https://github.com/apache/iceberg-cpp.git main && git rebase FETCH_HEAD (failed due to network/proxy restriction: CONNECT tunnel failed, response 403)

View task →

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2a34b53b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/iceberg/parquet/parquet_writer.cc Outdated
@manuzhang manuzhang force-pushed the codex/support-unknown-v3-type branch 3 times, most recently from db6029f to d5cc547 Compare May 28, 2026 08:50
@manuzhang
Copy link
Copy Markdown
Owner Author

manuzhang commented May 28, 2026

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5cc547d96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/iceberg/type_fwd.h
@manuzhang manuzhang force-pushed the codex/support-unknown-v3-type branch from d5cc547 to a510c76 Compare May 28, 2026 09:04
@manuzhang
Copy link
Copy Markdown
Owner Author

manuzhang commented May 28, 2026

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a510c76e9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/iceberg/json_serde.cc
@manuzhang manuzhang force-pushed the codex/support-unknown-v3-type branch from a510c76 to 7f87846 Compare May 28, 2026 09:21
@manuzhang
Copy link
Copy Markdown
Owner Author

manuzhang commented May 28, 2026

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f87846d44

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/iceberg/parquet/parquet_writer.cc Outdated
@manuzhang manuzhang force-pushed the codex/support-unknown-v3-type branch from 7f87846 to 62cf4ba Compare May 28, 2026 11:47
@manuzhang
Copy link
Copy Markdown
Owner Author

manuzhang commented May 28, 2026

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62cf4ba763

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/iceberg/avro/avro_schema_util.cc
@manuzhang manuzhang force-pushed the codex/support-unknown-v3-type branch 3 times, most recently from 34651d7 to 2757796 Compare May 28, 2026 12:14
@manuzhang
Copy link
Copy Markdown
Owner Author

manuzhang commented May 28, 2026

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 275779633b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/iceberg/avro/avro_writer.cc Outdated
@manuzhang manuzhang force-pushed the codex/support-unknown-v3-type branch 3 times, most recently from fc39adf to 6ecfa42 Compare May 29, 2026 01:59
@manuzhang
Copy link
Copy Markdown
Owner Author

manuzhang commented May 29, 2026

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 29, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ecfa42951

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/iceberg/util/type_util.cc
@manuzhang manuzhang force-pushed the codex/support-unknown-v3-type branch from 6ecfa42 to 2700fc8 Compare May 29, 2026 03:30
@manuzhang @codex
feat: support Iceberg v3 unknown type
5748be2 
Add an Iceberg unknown primitive type and JSON, Arrow, Avro, Parquet, projection, and data path support for null-only unknown fields. Enforce optionality invariants so required projections cannot be materialized from unknown/null-only fields.

Co-authored-by: Codex <codex@openai.com>

test: cover forbidden nested type promotions

Assert that promotion helpers reject nested type targets for unknown and regular primitive source types.

Co-authored-by: Codex <codex@openai.com>
@manuzhang manuzhang force-pushed the codex/support-unknown-v3-type branch from 2700fc8 to 5748be2 Compare May 29, 2026 03:58
@manuzhang
Copy link
Copy Markdown
Owner Author

manuzhang commented May 29, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented May 29, 2026

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@manuzhang