Refactor API controllers for security and performance#1
Open
manyasiingh wants to merge 3 commits intomainfrom
Open
Refactor API controllers for security and performance#1manyasiingh wants to merge 3 commits intomainfrom
manyasiingh wants to merge 3 commits intomainfrom
Conversation
Hirwa123-Saraiya
force-pushed
the
main
branch
from
709e849 to
cb7210f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored API controllers code of Admin , About Content and User Services for better security and performance
For AboutContentController.cs
The main area for improvement is to adopt RESTful API design best practices, specifically by changing the PUT method to align with standard conventions for resource updates.
For AdminController.cs
There are several areas where the code can be optimized for performance, readability, and consistency. The existing code makes multiple separate calls to the database to retrieve different pieces of information, which can be inefficient.
For UserServiceController.cs
There are significant security vulnerabilities and areas for improvement in code hygiene, consistency, and separation of concerns. The most critical issue is the lack of password hashing, which stores user passwords in plain text.