-
Notifications
You must be signed in to change notification settings - Fork 416
Fix missing HibernateAccounting class #3949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
04076fd to
a1cc61f
Compare
sebr72
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes. Could you please add a test, justifying why these changes were required ?
core/src/main/java/org/mapfish/print/servlet/job/impl/hibernate/PrintJobDao.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/servlet/job/impl/hibernate/PrintJobDao.java
Show resolved
Hide resolved
The failure happens because of the difference in the mapfish_spring_hibernate.xml files:
So the tests were not validating the behavior at runtime. |
|
The last commit (ef04b27) is needed to reduce amount of the database structure changes, e.g.:
The full DB structure comparison was done using the following steps:
The results were in line with expectations:
|
No description provided.