Conversation
- Replace exit 1 with return 1 in debian/bootstrap and install-jetbrains-tools so failures don't kill the user's shell when scripts are run via 'source <(curl ...)' - Add 'Bootstrap complete!' message at end of debian/bootstrap so the user knows when the run has finished (previously the script ended silently after github-auth-login) - Fix install-makemkv to use 'command -v' instead of 'type' to suppress spurious output when checking for makemkv - Add descriptive error messages to all return 1 paths in install-makemkv so failures explain what went wrong Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two issues reported when running the Debian bootstrap:
Bootstrap appeared to hang/end after GitHub login — the script ended silently with no output after
gh auth logincompleted (only two silentusermodcommands followed).MakeMKV selected but not installed on first run — tar extraction failures (especially the large
ffmpeg-snapshot.tar.bz2) were silent, causing subsequentpushdcalls to fail and bail out with no explanation.There was also a latent bug in both
debian/bootstrapandinstall-jetbrains-toolswhereexit 1was used in scripts that are always run viasource <(curl ...). Usingexitin a sourced script kills the user's entire shell session instead of just returning from the script.Changes
generic/install-jetbrains-tools: Replaceexit 1withreturn 1debian/install-makemkv: Usecommand -vinstead oftypeto suppress spurious output; add descriptive error messages to allreturn 1failure paths so the user knows what went wrong