Skip to content

"#53 the gradle version was updated to the latest, as well the java v… #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stianrincon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

"#53 the gradle version was updated to the latest, as well the java v… #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions mapstruct-on-gradle/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,23 @@
plugins {
id 'java'
id 'net.ltgt.apt' version '0.9'
id 'net.ltgt.apt' version '0.20'
}

repositories {
mavenCentral()
mavenLocal()
}

task wrapper(type: Wrapper) {
gradleVersion = '3.4'
}

ext {
mapstructVersion = "1.3.0.Beta2"
}

sourceCompatibility = JavaVersion.VERSION_1_8
sourceCompatibility = "11"
Copy link
Member

@filiphr filiphr Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should this be 11?

Copy link
Author

@stianrincon stianrincon Feb 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guys, thanks for replying, I will remove .DS_Store file. And about sourceCompatibility = 11 it was as a way to have the example with the latest java. But if it was not good I can keep it as sourceCompatibility = JavaVersion.VERSION_1_8. So @filiphr you please just let me know.

Copy link
Member

@filiphr filiphr Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep 1.8. We can add a comment that people can put 11 and it would work.

Copy link
Author

@stianrincon stianrincon Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I will

Copy link

@JoshMcCullough JoshMcCullough Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for these changes and getting this PR merged!


dependencies {
compile "org.mapstruct:mapstruct:${mapstructVersion}"
testCompile 'org.testng:testng:6.10', 'org.easytesting:fest-assert:1.4'
apt "org.mapstruct:mapstruct-processor:${mapstructVersion}"
implementation "org.mapstruct:mapstruct:${mapstructVersion}"
testImplementation 'org.testng:testng:6.10', 'org.easytesting:fest-assert:1.4'
annotationProcessor "org.mapstruct:mapstruct-processor:${mapstructVersion}"
}

tasks.withType(JavaCompile) {
Expand Down
Binary file added mapstruct-on-gradle/gradle/.DS_Store
View file
Open in desktop
Binary file not shown.
Binary file modified mapstruct-on-gradle/gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
3 changes: 1 addition & 2 deletions mapstruct-on-gradle/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#Sat Feb 25 23:47:27 CET 2017
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.1.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-3.4-bin.zip
72 changes: 42 additions & 30 deletions mapstruct-on-gradle/gradlew
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 4 additions & 10 deletions mapstruct-on-gradle/gradlew.bat
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.