Skip to content

Add web app serve#4

Merged
AdityaKhatri merged 13 commits into
developfrom
feature/add-web-app-serve
Aug 25, 2025
Merged

Add web app serve#4
AdityaKhatri merged 13 commits into
developfrom
feature/add-web-app-serve

Conversation

@subinasr
Copy link
Copy Markdown
Contributor

@subinasr subinasr commented Aug 12, 2025

Changes

  • Switch to vite and pnpm
  • Switch to react-router
  • Add web-app-serve

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • build works
  • eslint issues
  • typescript issues
  • codegen errors
  • console.log meant for debugging
  • typos
  • unwanted comments
  • conflict markers

@subinasr subinasr requested a review from AdityaKhatri August 12, 2025 15:43
@@ -1,12 +0,0 @@
import { InitializeOptions } from 'react-ga';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure?

Comment thread app/Base/context/UserContext.ts Outdated
@@ -0,0 +1,20 @@
import { createContext } from 'react';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary

Comment thread app/Base/context/ProjectContext.ts Outdated
@@ -0,0 +1,18 @@
import { createContext } from 'react';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary

Comment thread app/Base/index.tsx
}

if (trackingId) {
ReactGA.initialize(trackingId, gaConfig);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets bring it back

Comment thread app/Base/types/project.ts Outdated
@@ -0,0 +1,5 @@
export type Project = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necesary

Comment thread app/hooks/useRouteMatching.tsx Outdated
Comment on lines +29 to +50
if (visibility === 'is-not-authenticated' && authenticated) {
return undefined;
}

if (visibility === 'is-authenticated' && !authenticated) {
return undefined;
}

const skipProjectPermissionCheck = (
!!project
&& !!attrs?.projectId
&& project.id !== attrs.projectId
);

if (
visibility === 'is-authenticated'
&& authenticated
&& checkPermissions
&& !checkPermissions(skipProjectPermissionCheck)
) {
return undefined;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these

Comment thread app/hooks/useRouteMatching.tsx Outdated
Comment on lines +4 to +5
import ProjectContext from '#base/context/ProjectContext';
import UserContext from '#base/context/UserContext';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required

Comment thread app/views/StatsBoard/index.tsx Outdated
Comment on lines +811 to +817
<NumberOutput
className={styles.areaOutput}
value={validateImageTotalArea}
normal
invalidText=""
unit="Sq. Km."
/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Comment thread .gitignore Outdated
Comment on lines 5 to 6
yarn-debug.log*
yarn-error.log*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Comment thread Dockerfile Outdated
&& apt-get install -y --no-install-recommends git \
&& rm -rf /var/lib/apt/lists/* \
# NOTE: yarn > 1.22.19 breaks yarn-install invoked by pnpm
&& npm install -g pnpm@10.6.1 yarn@1.22.19 --force \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove yarn

@subinasr subinasr force-pushed the feature/add-web-app-serve branch from a2d437c to c706218 Compare August 17, 2025 08:15
@AdityaKhatri AdityaKhatri force-pushed the feature/add-web-app-serve branch 4 times, most recently from 7b6f789 to 002ba5d Compare August 25, 2025 05:39
@AdityaKhatri AdityaKhatri force-pushed the feature/add-web-app-serve branch from 002ba5d to e310935 Compare August 25, 2025 06:33
@AdityaKhatri AdityaKhatri force-pushed the feature/add-web-app-serve branch from e310935 to 9f1a6dc Compare August 25, 2025 06:35
@AdityaKhatri AdityaKhatri merged commit 64dd579 into develop Aug 25, 2025
2 checks passed
@AdityaKhatri AdityaKhatri deleted the feature/add-web-app-serve branch August 25, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants