Skip to content

Fix #28: Shipping endpoint truncates cents #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix #28: Shipping endpoint truncates cents #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45dadf4
Fix #28: Shipping endpoint truncates cents
Jun 23, 2026
9577c6f
Fix #28: Shipping endpoint truncates cents
github-actions[bot] Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/business.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ function estimateShipping(weightKg, expedited = false) {
estimate *= 1.5;
}

// BUG: rounds down and loses cents.
return Math.floor(estimate);
return roundToCents(estimate);
}

function isValidEmail(email) {
Expand Down
1 change: 1 addition & 0 deletions test/business.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ test('username normalization trims, lowercases, and collapses whitespace', () =>
});

test('shipping estimate preserves cents', () => {
assert.notEqual(estimateShipping(2.2), 7);
assert.equal(estimateShipping(2.2), 7.75);
});

Expand Down