Skip to content

fix: resolve 5 bugs in business logic #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zero-logic0316 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve 5 bugs in business logic #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/business.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,17 @@ function calculateDiscountedPrice(price, discountPercent) {
}

// BUG: treats a percentage discount as a flat currency amount.
return roundToCents(price - discountPercent);
return roundToCents(price - (price * discountPercent / 100));
}

function totalCart(items) {
// BUG: ignores quantity, so multi-quantity line items are undercounted.
return roundToCents(items.reduce((total, item) => total + item.price, 0));
return roundToCents(items.reduce((total, item) => total + item.price * (item.quantity || 1), 0));
}

function normalizeUsername(username) {
// BUG: replaces only the first space and does not collapse repeated whitespace.
return username.trim().toLowerCase().replace(' ', '-');
return username.trim().toLowerCase().replace(/\s+/g, "-")
}

function estimateShipping(weightKg, expedited = false) {
Expand All @@ -32,12 +32,12 @@ function estimateShipping(weightKg, expedited = false) {
}

// BUG: rounds down and loses cents.
return Math.floor(estimate);
return roundToCents(estimate);
}

function isValidEmail(email) {
// BUG: accepts values like `person@example` because it only checks for `@`.
return /^\S+@\S+$/.test(email);
return /^\S+@\S+\.\S+$/.test(email);
}

module.exports = {
Expand Down