feat(torin): Add layout order#1968
Conversation
Add `Direction::HorizontalReverse` and `Direction::VerticalReverse`, which stack children along the same axis in reverse order so a layout can be reversed without reordering its children.
|
Sure thing pal (bot) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1968 +/- ##
==========================================
+ Coverage 61.17% 61.35% +0.18%
==========================================
Files 331 333 +2
Lines 43106 43375 +269
==========================================
+ Hits 26370 26614 +244
- Misses 16736 16761 +25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
hey @marc2332, all of your code is generated by claude, so quit projecting. What a bot. |
I don't know where you take that from, I started this project before Claude was even created. Your account shows signs of massive vibecoded PRs spam in other projects, if you find this to be wrong please open a new PR with your changes. |
|
|
Tell me what exactly is the problem with this code. Does it not work? Do you not want it? Do you not want to read the commits? Make yourself clear. |
|
I don't want to waste my time reviewing code that was vibe coded (different from relying on AI). Your account activity does not inspire me confidence, therefore I decided it was not worth my time. |
|
Your complaint seems to fall under Goodhart's law of useless metrics. I did plenty testing of the code. |
|
As a sign of good gesture I will review the code soon, but again, your account activity is nothing but unusual. |
|
Thank you. |
| /// Stack children vertically, in reverse order. | ||
| VerticalReverse, | ||
| /// Stack children horizontally, in reverse order. | ||
| HorizontalReverse, |
There was a problem hiding this comment.
I would have rather added a flag to Vertical and horizontal
There was a problem hiding this comment.
I am not even sure if Direction is the right api to touch.
There was a problem hiding this comment.
Virtual Scrollview doesnt work with the reversed direction.
There is still an IF comparing to Direction::vertical(), but even if you fix that it s still broken because the children need to be reversed.
|
I'll take over this PR |
marc2332
changed the title
2 participants
Closes #1796
Adds a new order attribute to torin's layout node, by default its set to forward, but can be changed to backwards.