Wlroots support for panic crash window#2003
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2003 +/- ##
==========================================
+ Coverage 62.11% 62.33% +0.21%
==========================================
Files 334 334
Lines 43593 43977 +384
==========================================
+ Hits 27079 27412 +333
- Misses 16514 16565 +51 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Okay, that's still not working with freya. |
|
Can you please explain the purpose of this PR? Was it to fix the other issue? And if so, why did you close it? |
|
@marc2332 I can open message windows in main fn But freya error window are not shown on panic. |
|
@marc2332 Partial fix. not full fix |
|
what specific feature of the ones you enabled does add support for wlroots? |
|
gtk3 + wayland ... rfd defaults to xdg. xdg-portal has to be disabled, if you pick gtk3. |
|
This is default if u want to look |
|
Just tested again. Things was fine, i had no window in debug mode, thats why i closed PR. In ideal conditions this should be configurable somewhere, not hard-coded. |
|
Your tests, why it errors instead of formatting himself |
|
You need to format the code. See contributing.md. |
Description
I got it working with this line. All features except XDG were put.
RFD Library updated btw. rfd = "0.17.2". I didn't put updated ver.
Motivation
No crash window
Checklist
[ + ] I have tested my changes.
[ - ] I used AI assistance (e.g. ChatGPT, Copilot, etc.) to write this code.
[ - ] I have added or updated documentation where relevant.
[ - ] I have added or updated tests where relevant.