Skip to content

Wlroots support for panic crash window#2003

Open
fengints wants to merge 1 commit into
marc2332:mainfrom
fengints:patch-1
Open

Wlroots support for panic crash window#2003
fengints wants to merge 1 commit into
marc2332:mainfrom
fengints:patch-1

Conversation

@fengints

@fengints fengints commented Jul 6, 2026

Copy link
Copy Markdown

Description

I got it working with this line. All features except XDG were put.
RFD Library updated btw. rfd = "0.17.2". I didn't put updated ver.

Motivation

No crash window

Checklist

  • [ + ] I have tested my changes.

  • [ - ] I used AI assistance (e.g. ChatGPT, Copilot, etc.) to write this code.

  • [ - ] I have added or updated documentation where relevant.

  • [ - ] I have added or updated tests where relevant.

@fengints fengints requested a review from marc2332 as a code owner July 6, 2026 19:58
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.33%. Comparing base (744094a) to head (f9886b6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
+ Coverage   62.11%   62.33%   +0.21%     
==========================================
  Files         334      334              
  Lines       43593    43977     +384     
==========================================
+ Hits        27079    27412     +333     
- Misses      16514    16565      +51     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fengints

fengints commented Jul 6, 2026

Copy link
Copy Markdown
Author

Okay, that's still not working with freya.
Screenshot from raw cargo init.

@fengints fengints closed this Jul 6, 2026
@marc2332

marc2332 commented Jul 6, 2026

Copy link
Copy Markdown
Owner

Can you please explain the purpose of this PR? Was it to fix the other issue? And if so, why did you close it?

@fengints

fengints commented Jul 6, 2026

Copy link
Copy Markdown
Author

@marc2332
PR adds rfd support to wlroots based system.

I can open message windows in main fn

rfd::MessageDialog::new()
        .set_title("Fatal Error")
        .set_description("qwer")
        .set_level(rfd::MessageLevel::Error)
        .show();

But freya error window are not shown on panic.
This needs further digging

@fengints

fengints commented Jul 6, 2026

Copy link
Copy Markdown
Author

@marc2332 Partial fix. not full fix
during tests i tested rfd windows, not panics in freya

@marc2332

marc2332 commented Jul 6, 2026

Copy link
Copy Markdown
Owner

what specific feature of the ones you enabled does add support for wlroots?

@fengints

fengints commented Jul 6, 2026

Copy link
Copy Markdown
Author

gtk3 + wayland ...
rest are just defaults.

rfd defaults to xdg. xdg-portal has to be disabled, if you pick gtk3.
pollster = async runtime. You can remove it if you don't need it

@fengints

fengints commented Jul 6, 2026

Copy link
Copy Markdown
Author

This is default if u want to look

Adding rfd v0.17.2 to dependencies
             Features:
             + pollster
             + wayland
             + wayland-backend
             + wayland-client
             + wayland-protocols
             + xdg-portal
             - common-controls-v6
             - file-handle-inner
             - glib-sys
             - gobject-sys
             - gtk-sys
             - gtk3

@fengints fengints reopened this Jul 6, 2026
@fengints

fengints commented Jul 7, 2026

Copy link
Copy Markdown
Author

Just tested again. Things was fine, i had no window in debug mode, thats why i closed PR.
Debug = crash
Release = OK, crash window shows before exit

In ideal conditions this should be configurable somewhere, not hard-coded.
But this is low priority task. Things works. That should be enough for most cases.

@fengints fengints changed the title Wlroots support Wlroots support for panic crash window Jul 7, 2026
@fengints

fengints commented Jul 7, 2026

Copy link
Copy Markdown
Author

Your tests, why it errors instead of formatting himself
Better be log: your code not formatted, ill take care of it

@marc2332

marc2332 commented Jul 7, 2026

Copy link
Copy Markdown
Owner

You need to format the code. See contributing.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants