Skip to content

Use @napi-rs/canvas in native engine to match pdfjs-dist #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ywang-clarify wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use @napi-rs/canvas in native engine to match pdfjs-dist #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/engines/NodeCanvasFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const Canvas = require("canvas");
const Canvas = require("@napi-rs/canvas");
const assert = require("assert").strict;

class NodeCanvasFactory {
Expand Down
8 changes: 4 additions & 4 deletions functions/engines/native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const NodeCanvasFactory = require("./NodeCanvasFactory");
const fs = require("fs-extra");
const path = require("path");
const Canvas = require("canvas");
const Canvas = require("@napi-rs/canvas");

let pdfjsLibPromise;
const getPdfjsLib = () => {
Expand Down Expand Up @@ -36,7 +36,7 @@ const pdfPageToPng = async (

await page.render(renderContext).promise;

const image = canvasAndContext.canvas.toBuffer();
const image = canvasAndContext.canvas.toBuffer("image/png");
const pngFileName = isSinglePage
? filename
: filename.replace(".png", `-${pageNumber - 1}.png`);
Expand Down Expand Up @@ -85,7 +85,7 @@ const applyMask = async (
coordinates.x1 - coordinates.x0,
coordinates.y1 - coordinates.y0,
);
fs.writeFileSync(pngFilePath, canvas.toBuffer());
fs.writeFileSync(pngFilePath, canvas.toBuffer("image/png"));
};

const applyCrop = async (
Expand All @@ -110,7 +110,7 @@ const applyCrop = async (
);
fs.writeFileSync(
pngFilePath.replace(".png", `-${index}.png`),
canvas.toBuffer(),
canvas.toBuffer("image/png"),
);
};

Expand Down
Loading