in repliace env, set hosts as Array to new Mongolian#102
Open
muddydixon wants to merge 1 commit intomarcello3d:masterfrom
Open
in repliace env, set hosts as Array to new Mongolian#102muddydixon wants to merge 1 commit intomarcello3d:masterfrom
muddydixon wants to merge 1 commit intomarcello3d:masterfrom
Conversation
Owner
|
This solution feels a bit hacky. I think it can be simplified. What if we only handled two cases: arguments and array? Then you could have something like: And the remainder of the code would be nearly identical. Even with that, I'm not convinced this is the right solution, though. Maybe In either case, I would like to see the Mongolian constructor get simpler, not more complex. |
Author
|
Thank you for you reply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have replica server info in Array
In master branch, we must set each arguments to create mongolian client to replica set, such that
But the number of servers are not specified in code, but are specified in config.
So in this patch, we can create mongolian client such that,