Open
Conversation
Owner
|
Is there some way we can build a test case for this? I'm not entirely convinced that the problem goes away with the new code branch. |
Author
|
The problem is a collection of the following:
Testing is not easy, the failure effect is that typical node scripts will hang (I guess because the server connection is open), whereas nodeunit may be forcing an exit() once all the test.done() have been called. You can easily test hanging on the console with the following script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fix will become obsolete when the node-mongodb dependency gets removed,
but here's a fix that worked for me in case others need it now.