Fix modules not found when running dist#8
Open
alancuriel wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Fixed the json parse error but there is an error when building the recipes for the product '9213' . Seems to not be able to handle multiple recipes for a product |
Contributor
Author
error happens when running this code |
Owner
|
Just letting you know that I am aware of this PR. I don't think this is the correct solution and need to set up this repo environment locally again as I have changed computers. I will take a look more carefully on the weekend. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this fixes it. Definitely try it out.
But I also get a runtime error when I run a query. It seems to fail at parsing the json response from the constructed url even though its seems correct. I tried querying product recipe for item '9213'