fix: apply full-repo audit findings (P1s + quick-win P2/P3)#149
Merged
Conversation
Remediation from the dogfooded full-repo orchestrator run (8 specialist
lenses). No P0 found; this clears the regressions the session's velocity
introduced plus a cluster of P2/P3 hygiene gaps.
P1
- a11y (SC 1.4.3): per-audit hero text failed contrast in light theme — the
scrim faded to transparent over a near-black photo. Scrim is now theme-aware:
strong everywhere in light (image reads as a subtle texture), fades to reveal
the full photo in dark (default), which is already contrast-safe.
- frontend/SEO: /reports pages shipped a 404 og:image (hardcoded bare
/opengraph-image). Dropped the manual override on all 4 routes so Next serves
the real hashed card.
- content: removed the "German-only output" claim from 7 audit-detail/standard
strings — it contradicted the bilingual positioning and a proof finding shown
as fixed.
P2
- frontend/SEO: JSON-LD `image` pointed at the same 404 path (audit-page,
landing). Audit pages now use the real hero webp; homepage omits it.
- perf: next.config images { formats: [avif, webp], minimumCacheTTL: 1y }.
- infra: aligned Vercel Node to 22.x to match .nvmrc/engines/CI (was 24.x).
- repo: web<->mcp catalogue parity is now enforced — mcp + web tests assert
their audit keys equal the audit-prompts/*.md key set (the single source);
corrected the catalogue comment that overclaimed CI protection.
- content: compliance-privacy DE rewritten with proper umlauts; fixed a broken
German verb and a grosse/ss inconsistency; de-anglicised two pseudo-German verbs.
- docs: documented the mcp/ package (README + ARCHITECTURE "two -> three"),
refreshed the stale web/README structure tree (audits/reports routes, new lib
files, hero-image convention, lint/test scripts); backfilled CHANGELOG.
- supply chain: Dependabot now covers /mcp.
P3
- ci: docs.yml gains a paths filter (was running a network link-check on every push).
- tests: new reports.test.ts (i18n key resolution + dedup invariant); the data
file that had zero coverage.
Deferred (noted in the report): gating the Vercel deploy on CI (dashboard
setting), signing CHECKSUMS.txt (key mgmt), and the <abbr> tooltip a11y polish.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remediation from the dogfooded full-repo orchestrator run (8 specialist lenses, read-only). No P0. Clears the 3 P1s + a cluster of P2/P3.
P1 — a11y hero-text contrast (theme-aware scrim) ·
/reports404 og:image · content "German-only output" contradiction.P2 — JSON-LD 404
image· AVIF + image cache TTL (next.config) · Vercel Node aligned to 22.x · web↔mcp catalogue parity now enforced by tests · DE umlauts/verb fixes · mcp/ documented + web/README refreshed + CHANGELOG backfilled · Dependabot covers/mcp.P3 — docs.yml paths filter · new
reports.test.ts.Deferred (in the report): Vercel deploy CI-gating (dashboard), CHECKSUMS signing (key mgmt),
<abbr>tooltip polish.Verified:
check-prompts13/13 ·checksums✓ · web typecheck/lint/28 tests/build 67/67 · mcp tests ✓.