font list as fallback; click to change font#1
Open
patarapolw wants to merge 6 commits intomarciska:mainfrom
Open
font list as fallback; click to change font#1patarapolw wants to merge 6 commits intomarciska:mainfrom
patarapolw wants to merge 6 commits intomarciska:mainfrom
Conversation
Owner
|
Do you want to retarget your PR to |
Author
|
I am not using WaniKani currently anyway, so not sure what would be broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canvas support isn't yet guaranteed. Checking for browser is an option, but there are probably better choices.
At least the fallback isn't always the default font. Before fix, sometimes it is a mixed between default font and random font.
Currently, font is sometimes mixed.
Click to change font is an additional feature, rather than a fix.
CTRL+J opens Download in Brave Browser, making it bad for changing fonts.