Adds docker support to project#86
Adds docker support to project#86isaacrlevin wants to merge 3 commits intomarcomaroni-github:mainfrom
Conversation
There was a problem hiding this comment.
@isaacrlevin There's a typo in the file extension (comma instead of dot).
There was a problem hiding this comment.
thanks for the headsup, fixed it
|
Thanks @isaacrlevin , I would like to align with the already merged change of support for a container present (in this PR), so as not to create confusion and have uniformity, then I also ask you to update the README accordingly, into the section already present in which it talks about the Dev Container. Feel free to completely change that section, I am not very expert in containers and I leave this part to you very willingly. Many thanks! |
No problem! Any issue with me publishing a version of image to my Docker Hub? Obviously I will give you credit but I can provide documentation on how to build the docker image yourself or just "Run the tool" with nothing else needed. |
No problem. |
|
@isaacrlevin did you publish this to docker? Have a link? |
yeaaaaa I totally did not do that. Will need to take a look and see if it is still straightforward |
4 participants
First off, great project! Kudos to you for putting in the work
The tool is pretty straightforward today, but I thought making it available via a docker container that a user could just run a
docker runcommand or create adocker composefile would make it even more accessible. How I see it you could do 2 thingsTake the Dockerfile in this PR and publish the image to your own Docker registry and provide a sample
docker composethat uses that image with some instructions on setting variables and Twitter data directlyJust provide a Dockerfile and let users do what they like with it.
Regardless I hope this is helpful and I am more than happy to change anything or add some documentation as well.