fix: eliminate Docker test flakiness and cut CI time#10
Merged
Conversation
- Cache Docker image layers in GitHub Actions (type=gha) so apt-get + Claude CLI + Codex CLI installs are not re-downloaded on every run; image build becomes a near-instant cache hit after the first run - Run all 4 integration test containers in parallel; each is isolated so there is no ordering dependency — wall-clock time drops to the slowest single container instead of the sum of all four - Skip `docker build` in test-docker.sh when the image is already loaded (CI pre-builds it via build-push-action); local dev still builds on demand - Remove `|| true` on Claude CLI install in Dockerfile so a failed install surfaces immediately rather than silently producing a broken test env - Drop the 3-attempt retry loop; the primary flakiness source was the fresh Docker image pull, which caching eliminates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type=gha) soapt-get+ Claude CLI + Codex CLI installs are not re-downloaded on every run — image build becomes a near-instant cache hit after the first pushdocker buildintest-docker.shwhen the image is already loaded by the CI pre-build step; local dev still builds on demand|| trueon Claude CLI install inDockerfileso a failed install surfaces immediately instead of silently producing a broken test environmentRoot causes addressed
|| trueon Claude CLI installExpected CI times
Test plan