Linter: Implement a11y-svg-has-accessible-text rule#1669
Open
joelhawksley wants to merge 9 commits into
Open
Conversation
Add a new linter rule that ensures `<svg>` elements have accessible text. The rule reports an offense when an `<svg>` is missing all of the following: - `aria-label` attribute - `aria-labelledby` attribute - A nested `<title>` child element SVGs marked as decorative with `aria-hidden="true"` are exempt. Based on the erblint-github `GitHub::Accessibility::SvgHasAccessibleText` rule. Closes marcoroth#1226
a11y-svg-has-accessible-text linter rulea11y-svg-has-accessible-text rule
marcoroth
reviewed
Jun 5, 2026
Signed-off-by: Marco Roth <marco.roth@intergga.ch>
marcoroth
added a commit
that referenced
this pull request
Jun 6, 2026
This pull request updates the AST utils related to elements and attributes in core to also account for the `HTMLConditionalOpenTagNode` node type, so linter rules like #1669 can more easily build the logic for the linter rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new linter rule that ensures
<svg>elements have accessible text. The rule reports an offense when an<svg>is missing all of the following:aria-labelattributearia-labelledbyattribute<title>child elementSVGs marked as decorative with
aria-hidden="true"are exempt.Based on the erblint-github
GitHub::Accessibility::SvgHasAccessibleTextrule.Closes #1226