Language Server: Fix comments inside multiline ERB tags#1776
Open
RSeven wants to merge 2 commits into
Open
Conversation
40af223 to
4337c30
Compare
4337c30 to
fb9db1a
Compare
Author
|
Not sure about how to handle toggleBlockComment for multiline ERB tags. I thought about keeping the if block but it creates some strange behaviours, for example:
<%
if false
if false
a
b
end
end
%>
<%
if false
if false
a
end
b
end
%> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes comment handling for Ruby lines inside multiline ERB tags.
Issues resolved
Before, commenting the internal Ruby line with toggleLineComment produced HTML comments inside Ruby:
After:
Before, block-commenting only the internal Ruby line with toggleBlockComment inserted nested ERB tags:
After:
Closes #1774