Skip to content

fix: metro not picking threaded runtime #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riteshshukla04 merged 2 commits into from
Jun 4, 2026
Merged

fix: metro not picking threaded runtime #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44a5c7c
fix: metro not picking threaded runtime
riteshshukla04 Jun 4, 2026
fbd83f6
chore: hopefully-ci
riteshshukla04 Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion packages/core/ios/ThreadedRuntime.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,7 +841,25 @@ + (RCTHost *)ensureHostWithRuntimeName:(NSString *)runtimeName
[[ThreadedRuntimeTurboModuleDelegate alloc] initWithDelegate:delegate];
__weak id<RCTReactNativeFactoryDelegate> weakDelegate = delegate;
RCTHostBundleURLProvider bundleURLProvider = ^NSURL *_Nullable {
return [weakDelegate bundleURL];
NSURL *url = [weakDelegate bundleURL];
if (url != nil) {
return url;
}
Class devLauncherClass = NSClassFromString(@"EXDevLauncherController");
if (devLauncherClass != nil) {
SEL sharedSel = NSSelectorFromString(@"sharedInstance");
SEL sourceUrlSel = NSSelectorFromString(@"sourceUrl");
if ([devLauncherClass respondsToSelector:sharedSel]) {
id controller = ((id (*)(id, SEL))objc_msgSend)(devLauncherClass, sharedSel);
if ([controller respondsToSelector:sourceUrlSel]) {
NSURL *devLauncherURL = ((NSURL *(*)(id, SEL))objc_msgSend)(controller, sourceUrlSel);
if (devLauncherURL != nil) {
return devLauncherURL;
}
}
}
}
return url; // nil — preserve original behavior for non-dev-client setups.
};
RCTHost *host = [[RCTHost alloc] initWithBundleURLProvider:bundleURLProvider
hostDelegate:hostDelegate
Expand Down
Loading