Skip to content

delete uv_work_t at end of callback#19

Open
steve-lawson wants to merge 1 commit intomariano:masterfrom
steve-lawson:master
Open

delete uv_work_t at end of callback#19
steve-lawson wants to merge 1 commit intomariano:masterfrom
steve-lawson:master

Conversation

@steve-lawson
Copy link
Copy Markdown

Found a small memory leak.

@mariano
Copy link
Copy Markdown
Owner

mariano commented May 16, 2014

Nice catch! Wouldn't it be better to delete the request from Execute itself instead of ExecuteFinished. Since request was created here, it probably makes more sense to delete it here

@steve-lawson
Copy link
Copy Markdown
Author

I think that request needs to stay around until the callback finishes, then it is deleted here, but req created here was not being deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants