Solve issue when tapping on a video#53
Open
chasseurmic wants to merge 1 commit intomariohahn:masterfrom
Open
Conversation
The following method `-(void)handelImageTap:(UIGestureRecognizer *)gestureRecognizer` in MHGalleryImageViewerViewController was crashing my app when tapping on a video presented inside the `MHGalleryController`. The problem was due to the selector `locationInView:` called on an instance of UIButton. The `handelImageTap` method should actually accept only instances of UIGestureRecognizer as its parameters, but in `changeToPlayable` the `self.moviewPlayerButtonBehinde` is being passed as a parameter, thus crashing the app. I've solved the issue by adding a gesture recognizer to `self.moviewPlayerButtonBehinde` and by adding a defensive check inside `handelImageTap`.
|
+1 |
|
@syrakozz i think this is resolved in the latest build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following method
-(void)handelImageTap:(UIGestureRecognizer *)gestureRecognizerin MHGalleryImageViewerViewController was crashing my app when tapping on a video presented inside theMHGalleryController. The problem was due to the selectorlocationInView:called on an instance of UIButton.The
handelImageTapmethod should actually accept only instances of UIGestureRecognizer as its parameters, but inchangeToPlayabletheself.moviewPlayerButtonBehindeis being passed as a parameter, thus crashing the app.I've solved the issue by adding a gesture recognizer to
self.moviewPlayerButtonBehindeand by adding a defensive check insidehandelImageTap.