Skip to content

Add prettyprinter as dev package to pipenv#50

Open
marius92mc wants to merge 1 commit into
masterfrom
add-prettyprinter-package
Open

Add prettyprinter as dev package to pipenv#50
marius92mc wants to merge 1 commit into
masterfrom
add-prettyprinter-package

Conversation

@marius92mc
Copy link
Copy Markdown
Owner

@marius92mc marius92mc commented Jan 27, 2018

This PR adds the prettyprinter package to pipenv as a dev package.

The reason for adding this package is because it can be really useful when inspecting in IPython and debugging in ipdb.

Issues:

  • CI, locally works fine.

FYI, @ignacio-chiazzo.

Comment thread Pipfile.lock
"sha256:d400a9344254803a2368533e4533a4200d21eb7b6b729c173bc38201a74db3f2"
],
"version": "==3.6.2"
"markers": "python_version <= '3.4'",
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new "markers" section seems to be newly added to pipenv.

Copy link
Copy Markdown
Collaborator

@ignacio-chiazzo ignacio-chiazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this addition. 👍

Comment thread Pipfile
name = "pypi"
url = "https://pypi.python.org/simple"


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who added these blank lines?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the answer here.

Comment thread Pipfile
pylint = "*"
requests = "*"
beautifulsoup4 = "*"
"beautifulsoup4" = "*"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecesary "". Can you confirm it was intentionally
Changed the - to "".

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the answer here.

@marius92mc
Copy link
Copy Markdown
Owner Author

marius92mc commented Jan 29, 2018

I will answer here to both of the above questions, @ignacio-chiazzo.

This PR content was automatically generated by the command.

$ pipenv install --dev prettyprinter

I didn't manually edit anything.

It is not the first time when I see pipenv adding that kind of content, as in "" and blanklines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants