fix: mkdir -p output dir + stub flaky execSync tests#26
Merged
Conversation
When --output points to a path whose parent directory doesn't exist, the cluster fails at completion. Create the directory tree first. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…E flake The two tests calling real shell commands (cat, echo) intermittently fail with spawnSync EPIPE in CI. Stub safeExec.execSync and assert on the args/env passed instead — matches the pattern used by the other tests in the same file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mkdir -pthe output directory beforewriteFileSyncin bothwrite-review-report.jsandassemble-doc.js— fixes ENOENT when--outputpoints to a non-existent directorysafeExec.execSyncin the twoexecute_system_commandtests that were calling real shell commands (cat,echo), causing intermittent EPIPE failures in CITest plan
🤖 Generated with Claude Code