fix: sanitize LLM-sourced quality gate commands#29
Merged
Conversation
LLM responses wrapped in inline backticks (`command`) were stored verbatim in project config. Shell interpreted backticks as command substitution, causing exit 127 on every quality gate run. Additionally, LLM-sourced commands were never invalidated on failure, creating a permanent stuck state. Three-layer fix: - sanitizeLLMResponse() strips inline backticks and leading $ prompts - ensureQualityConfig() retroactively sanitizes existing poisoned configs - quality-gate-runner flags failed LLM commands as llm-failed for re-detection Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`command`) stored verbatim in project config. Shell interpreted backticks as command substitution → exit 127 on every quality gate run.Three-layer fix
sanitizeLLMResponse()strips inline backticks and leading$prompts.ensureQualityConfig()retroactively sanitizes existing poisoned configs.quality-gate-runnerflags failed LLM commands asllm-failedfor re-detection.Test plan
tests/quality-detection.test.jscases for sanitizer + config repair.tests/quality-gate.test.jsupdated to exercise failure → re-detection path.🤖 Generated with Claude Code