fix(frontend): close undo-after-commit race; docs: pitch-first README - #55
Closed
markadams31 wants to merge 2 commits into
Closed
fix(frontend): close undo-after-commit race; docs: pitch-first README#55markadams31 wants to merge 2 commits into
markadams31 wants to merge 2 commits into
Conversation
…y committed The Undo action stayed wired up through the entire delete commit and success-toast lifecycle, so a click landing after the server DELETE had already succeeded would restore the row in the client cache while it stayed permanently deleted in the database — a false "restored" state contradicted by the next background refetch. Undo now no-ops once commit() starts, and the toast explicitly clears its action at that point (Sonner merges toast updates shallowly, so omitting `action` isn't enough — the previous button would otherwise persist). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Reorders sections so the strongest technical decisions (zero-trust SQL authorization, the twice-run golden-snapshot integration tests, the OpenTelemetry silent-failure catch) surface in a new Highlights section right after the intro, rather than several hundred lines down. Adds a one-line tech-stack callout for scanners. All existing technical content is preserved, just reordered and tightened. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
markadams31
force-pushed
the
fix/undo-race-condition
branch
from
July 5, 2026 01:27
cbc4bc4 to
0ba2b2d
Compare
markadams31
changed the title
Owner
Author
|
Closing: the two commits this PR carries (9f89345 undo-race fix, 0ba2b2d README restructure) were already squash-merged into main via #54 (d582387), so this PR's effective diff is empty. The descoped review fixes (delete/undo concurrency rework, server-default-PK creates, strict bulk filters) remain parked on the local branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits:
commit()starts, and the toast explicitly clears its action at that point (Sonner merges toast updates shallowly, so omittingactionisn't enough).A broader set of review-driven fixes (delete/undo concurrency rework, server-default-PK creates, strict bulk filters) was developed and verified on this branch but deliberately descoped — this is a portfolio demo app and can live without them. That work is parked locally on
parked/review-fixesif it's ever wanted.🤖 Generated with Claude Code