Skip to content

SilverStripe 3.0 compatibility#21

Open
DarrenInwood wants to merge 2 commits into
markguinn:masterfrom
DarrenInwood:compat
Open

SilverStripe 3.0 compatibility#21
DarrenInwood wants to merge 2 commits into
markguinn:masterfrom
DarrenInwood:compat

Conversation

@DarrenInwood

Copy link
Copy Markdown

In case you would like a branch that can be installed on older 3.0 projects.

@markguinn

Copy link
Copy Markdown
Owner

Thanks @DarrenInwood I'll merge this as soon as I can - probably into a separate branch because of the public/private statics issue. This is good to have available though.

@DarrenInwood

Copy link
Copy Markdown
Author

I didn't do anything with the tests btw.
On 15/07/2015 9:59 pm, "Mark Guinn" notifications@github.com wrote:

Thanks @DarrenInwood https://github.com/DarrenInwood I'll merge this as
soon as I can - probably into a separate branch because of the
public/private statics issue. This is good to have available though.


Reply to this email directly or view it on GitHub
#21 (comment)
.

@markguinn

Copy link
Copy Markdown
Owner

That's fine. It's working on a site of yours though?

@markguinn

Copy link
Copy Markdown
Owner

I pulled this down as a branch called compat-3.0 but it's failing a lot of tests in Travis (https://travis-ci.org/markguinn/silverstripe-cloudassets/jobs/71474142). I'm happy to leave the branch up but I don't have time to debug all those. If you have time and would like to do take it the rest of the way, feel free. You can either work off a fork and submit a pull request directly to that branch or I could make you a collaborator and you could push directly to the compat-3.0 branch. If you don't have time, no worries. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants