Skip to content

Conversation

@stevebio
Copy link
Collaborator

We're releasing node client 4.1.0 with typescript support. The new optic functions should not be included until version of ML required has been released. Reverting all of the new optic work until the next node release.

@github-actions
Copy link

Copyright Validation Results
Total: 6 | Passed: 0 | Failed: 6 | Skipped: 0 | at: 2026-01-28 18:13:34 UTC | commit: 5518e9c

❌ Failed Files

  • lib/plan-builder-base.js

    Error:

    - Copyright format does not match expected format

    Expected header:

    Copyright (c) 2015-2026 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
    
  • lib/plan-builder-generated.js

    Error:

    - Copyright format does not match expected format

    Expected header:

    Copyright (c) 2015-2026 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
    
  • test-basic/optic-vector.js

    Error:

    - Copyright format does not match expected format

    Expected header:

    Copyright (c) 2015-2026 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
    
  • test-basic/plan-builder-generated.js

    Error:

    - Copyright format does not match expected format

    Expected header:

    Copyright (c) 2015-2026 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
    
  • test-basic/service-caller.js

    Error:

    - Copyright format does not match expected format

    Expected header:

    Copyright (c) 2015-2026 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
    
  • test-basic/ssl-min-allow-tls-test.js

    Error:

    - Copyright format does not match expected format

    Expected header:

    Copyright (c) 2015-2026 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
    

🛠️ Guidance

Follow these steps to fix the failed files:

  1. Insert the expected header at the very top (within first 20 lines) of each failed file.
  2. Ensure the year range matches the configuration (start year through current year).
  3. Do not alter spacing or punctuation in the header line.
  4. Commit and push the changes to update this check.

@stevebio stevebio marked this pull request as ready for review January 28, 2026 18:32
Copilot AI review requested due to automatic review settings January 28, 2026 18:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts optic changes introduced for transitive closure and fromDocs functionality that depend on an unreleased version of MarkLogic. The changes prepare the node client 4.1.0 release with TypeScript support by removing features that require a future ML server version.

Changes:

  • Removed transitive closure test files and related triple set data
  • Removed fromDocs optic test file
  • Reverted copyright year from 2026 to 2025
  • Removed new vector function implementations (precision, trunc) and ColumnBuilder class
  • Simplified vector function tests and restored original test implementations

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test-basic/transitive-closure.js Complete removal of transitive closure tests
test-app/src/main/ml-data/optic/transitive-closure/* Removal of test data files for transitive closure
test-basic/optic-fromDocs.js Complete removal of fromDocs tests
test-basic/ssl-min-allow-tls-test.js Minor timeout adjustment
test-basic/service-caller.js Re-enabled previously skipped test
test-basic/plan-builder-generated.js Reverted copyright and simplified base64Decode test
test-basic/optic-vector.js Reverted copyright, simplified tests, and changed plan builder variable name
lib/plan-builder-generated.js Removed ColumnBuilder, fromDocs, transitiveClosure, context, precision, and trunc functions
lib/plan-builder-base.js Reverted copyright and removed transitive closure options handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stevebio stevebio merged commit 407bd07 into develop Jan 28, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants