-
Notifications
You must be signed in to change notification settings - Fork 52
MLE-12345: revert new optic changes #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Copyright Validation Results ❌ Failed Files
🛠️ GuidanceFollow these steps to fix the failed files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reverts optic changes introduced for transitive closure and fromDocs functionality that depend on an unreleased version of MarkLogic. The changes prepare the node client 4.1.0 release with TypeScript support by removing features that require a future ML server version.
Changes:
- Removed transitive closure test files and related triple set data
- Removed fromDocs optic test file
- Reverted copyright year from 2026 to 2025
- Removed new vector function implementations (precision, trunc) and ColumnBuilder class
- Simplified vector function tests and restored original test implementations
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test-basic/transitive-closure.js | Complete removal of transitive closure tests |
| test-app/src/main/ml-data/optic/transitive-closure/* | Removal of test data files for transitive closure |
| test-basic/optic-fromDocs.js | Complete removal of fromDocs tests |
| test-basic/ssl-min-allow-tls-test.js | Minor timeout adjustment |
| test-basic/service-caller.js | Re-enabled previously skipped test |
| test-basic/plan-builder-generated.js | Reverted copyright and simplified base64Decode test |
| test-basic/optic-vector.js | Reverted copyright, simplified tests, and changed plan builder variable name |
| lib/plan-builder-generated.js | Removed ColumnBuilder, fromDocs, transitiveClosure, context, precision, and trunc functions |
| lib/plan-builder-base.js | Reverted copyright and removed transitive closure options handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
We're releasing node client 4.1.0 with typescript support. The new optic functions should not be included until version of ML required has been released. Reverting all of the new optic work until the next node release.