ci: add bats workflow#29
Merged
Merged
Conversation
Sorting-hat has 62 bats tests as of #25/#27 but no CI to run them on PRs — regressions can creep in undetected. Adds a bats workflow: - Installs bats + bats-assert + bats-support via apt (Ubuntu) - Symlinks the apt-installed paths into the Arch-convention path /usr/lib/bats/<lib>/load that test.sh hard-codes, so Markus's local Arch test runs stay untouched (no cross-distro logic in the test file) - Also installs ffmpeg + jq (collect_metadata audio tests need ffprobe; jq is generally useful for any future test that inspects mock JSON) - Runs 'bats test.sh' on push to main and on every PR Path-discovery uses 'find /usr/lib /usr/share -path *bats-<lib>/load.bash' to tolerate both /usr/lib/bats-assert/ and /usr/share/bats-assert/ layouts across Ubuntu versions.
This was referenced Jun 26, 2026
marksverdhei
added a commit
that referenced
this pull request
Jun 27, 2026
Adds (newest first, matching existing style): - #32 stem-less dotfile guard - #30 video file support - #28 --preview / -p flag - #27 is_audio ftyp false-positive fix - #20 audio file support Skipped pure-docs (#15, #16, #17, #31), CI infra (#29), and test-only rebases (#25) — same selection rule the prior entries used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Sorting-hat has 62 bats tests as of #25 / #27 (the rounds of test additions I just landed) but no CI runs them on PRs. Any future PR could land a regression undetected — including PRs from hai-pilgrim or other contributors, which is the most likely vector.
How
Verified locally
`bats test.sh` passes 62/62 on my Arch dev machine. The CI step list is short enough to inspect — if Ubuntu's bats packaging shifts paths in the future, the `find`-based discovery should adapt.