Merged
Conversation
CyrilleB79
reviewed
May 28, 2024
Contributor
CyrilleB79
left a comment
CyrilleB79
left a comment
There was a problem hiding this comment.
There was a bug (extra self) that I had to fix.
Once fixed, the dialog looks nice visually, at least with my sight: the controls seem to be correctly placed in the dialog (no overlap).
Owner
Author
|
Thanks for suggestions. All of them have been applied. |
|
Hi. I'm not a professional or even unprofessional github user. I was wondering what the status of this is? I wish to use regex to look for multiple words in a given document / page. |
Owner
Author
|
Hello, The status of this is exactly waiting on free time from me or other people who can make it. This is also something I personally want, and will be made. Please use #24 to track progress. |
marlon-sousa
force-pushed
the
feat/implement-search-by-regular-expressions
branch
from
450c4a2 to
deb7a04
Compare
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
…the end of the text
thgcode
force-pushed
the
feat/implement-search-by-regular-expressions
branch
from
3454aa9 to
3c04e3d
Compare
thgcode
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pr, we implement searching using regular expression