fix: resolve react-hooks/set-state-in-effect lint error in GameProvider - #29
Merged
Merged
Conversation
Replaces the prevRankRef + useEffect promotion detector with the render-phase state-adjustment pattern recommended by the React docs, resolving the react-hooks/set-state-in-effect lint error. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dsq9LChvMw1JVyhQj9roav
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI lint was failing on
src/components/GameProvider.tsxwith areact-hooks/set-state-in-effecterror: the rank-promotion detector calledsetPromotionRanksynchronously inside auseEffect, which can trigger cascading renders.This replaces the
prevRankRef+useEffectcombination with the render-phase state-adjustment pattern recommended by the React docs (You Might Not Need an Effect): the previous rank is tracked in state, and when it differs from the current rank during render, the promotion banner state is updated immediately — no effect, no extra committed render of stale UI.Behavior is unchanged: the banner still doesn't fire on the initial render (previous rank starts as
null), and fires whenever the rank name changes afterwards.Verification
npm run lint— passes (exit 0)npx tsc --noEmit— passes (exit 0)🤖 Generated with Claude Code
https://claude.ai/code/session_01Dsq9LChvMw1JVyhQj9roav
Generated by Claude Code