feat: add a replace command that can be used to handle module relocation and rename#26
Open
xNok wants to merge 5 commits intomarwan-at-work:masterfrom
Open
feat: add a replace command that can be used to handle module relocation and rename#26xNok wants to merge 5 commits intomarwan-at-work:masterfrom
xNok wants to merge 5 commits intomarwan-at-work:masterfrom
Conversation
6 tasks
|
Giving this a go (as part of renovatebot/renovate#29575) with https://github.com/jamietanna/renovate-iss-oapi I'm finding this doesn't quite work. For instance: This then results in the following diff: -require github.com/deepmap/oapi-codegen v1.12.0
+require github.com/deepmap/oapi-codegen v1.16.3Whereas I'd expect to see: -require github.com/deepmap/oapi-codegen v1.12.0
+require github.com/oapi-codegen/oapi-codegen/v2 v2.3.1Any idea why? I'd assume that after executing this, I'd also see a change in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered your utility via Renovate, which uses it to handle the major upgrade workflow. The module is conveniently called mod, so it could be extended to auto-resolve all the mod-related issues.
Renovate recently introduced the "replacement" feature that can be used to update the dependencies for which the package name has changed. Unfortunately, the gomod manager is not supported, so I am planning to do the work and get it implemented.
There are a few cases where this happens in go
My renovate branch for this feature: https://github.com/xNok/renovate/tree/replacement-for-gomod