Draft
Conversation
coryodaniel
commented
Nov 9, 2025
| name | ||
| } | ||
| } | ||
| artifacts { |
Member
Author
There was a problem hiding this comment.
Probably a bit more than we actually need lol.
Member
Author
|
I'm going to break this into a few smaller PRs. No need to approve. |
coryodaniel
commented
Nov 11, 2025
coryodaniel
commented
Nov 11, 2025
Comment on lines
+232
to
+240
| if pkgParamsPath == "-" { | ||
| // Read from stdin | ||
| if err := json.NewDecoder(os.Stdin).Decode(¶ms); err != nil { | ||
| return fmt.Errorf("failed to decode JSON from stdin: %w", err) | ||
| } | ||
| } else { | ||
| if err := files.Read(pkgParamsPath, ¶ms); err != nil { | ||
| return err | ||
| } |
Member
Author
There was a problem hiding this comment.
moved to new pr
Suggested change
| if pkgParamsPath == "-" { | |
| // Read from stdin | |
| if err := json.NewDecoder(os.Stdin).Decode(¶ms); err != nil { | |
| return fmt.Errorf("failed to decode JSON from stdin: %w", err) | |
| } | |
| } else { | |
| if err := files.Read(pkgParamsPath, ¶ms); err != nil { | |
| return err | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking this into a few smaller prs:
mass pkg getfull markdown reportPackage GET
Markdown report
Full JSON object
Package Configure STDIN support