Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #49, I made a list of the endpoints that (at the time) I believed were missing.
After finding some time to sit down and go through the document, I think I've made the relevant adjustments to cover a large number of missing endpoints.
I apologise for the massive wall of text that's about to follow, but it documents where I've got to with filling in the gaps.
Unfortunately, this only covers the REST endpoints, not streaming endpoints. Additionally, these changes lack tests, which is also my fault. However, I didn't feel justified in spamming mastodon.social with test runs. Where possible, I have tested the endpoints manually using botsin.space as a test instance, and using
binding.irbcalls.If there is anything that you would like me to do to aid the closure of #49, I will make it a priority from my perspective so that the gem can get a new release.
I don't typically use GitHub for development, so I also apologise if this is not correct behaviour.
Endpoints I falsely stated were missing
GET/api/v1/accounts/#{id}/statusesPOST/api/v1/accounts/#{id}/pinPOST/api/v1/accounts/#{id}/unpinGET/api/v1/suggestionsDELETE/api/v1/suggestions/#{account_id}POST/api/v1/reportsPOST/api/v1/notifications/#{id}/dismissEndpoints that I've implemented in the Gem
GET/api/v1/accounts/#{id}/listsGET/api/v1/accounts/#{id}/identity_proofsGET/api/v1/favouritesGET/api/v1/featured_tagsPOST/api/v1/featured_tagsDELETE/api/v1/featured_tags/#{id}GET/api/v1/featured_tags/suggestionsPOST/api/v1/oauth/tokenPOST/api/v1/oauth/revokeGET/api/v1/polls/#{id}POST/api/v1/polls/#{id}/votesGET/api/v1/notifications/#{id}POST/api/v1/push/subscriptionGET/api/v1/push/subscriptionPUT/api/v1/push/subscriptionDELETE/api/v1/push/subscriptionGET/api/v1/directoryGET/api/v1/trendsGET/api/v1/announcementsPOST/api/v1/announcements/#{id}/dismissPUT/api/v1/announcements/#{id}/reactions/#{name}DELETE/api/v1/announcements/#{id}/reactions/#{name}Endpoints I'm not sure about
GET/api/v1/bookmarksGET/api/v1/reports<string>:<string>:<string>))GET/api/v1/preferencesGET/api/v1/oauth/authorizeFilepassed through to request)GET/api/v1/media/#{id}Mastodon::MarkerCollectionor similar), with sub-objects ofMastodon::Marker?)GET/api/v1/markersPOST/api/v1/markersGET/api/proofsGET/api/oembed