release: v0.3.5 — fix MenuButton caret in forced-colors mode#174
Merged
Conversation
The dropdown caret on `.apg-menu-button-trigger::after` is drawn with the classic CSS triangle hack (width:0, height:0, transparent left/right borders, colored top border). In Windows High Contrast Mode, browsers substitute `transparent` with a system color, so left/right borders fill in and the triangle becomes a solid 8x4 rectangle — the expand/collapse direction is no longer readable. Add `forced-color-adjust: none` to the `::after` so transparent stays transparent. `currentColor` still inherits the trigger's `color: ButtonText`, so the top border renders correctly and the 180deg rotate on `[aria-expanded='true']` is visible again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying apg-patterns-examples with
|
| Latest commit: |
65bf4de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1dcc45ff.apg-patterns-examples.pages.dev |
| Branch Preview URL: | https://release-v0-3-5.apg-patterns-examples.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
width:0; height:0;+border-left/right: transparent; border-top: currentColor). In forced-colors mode, browsers substitutetransparentwith a system color, so the "triangle" becomes a filled 8×4 box.forced-color-adjust: noneto.apg-menu-button-trigger::after. Transparent borders stay transparent;currentColorstill inherits the trigger'sButtonText, so the top border renders and the 180° rotate on[aria-expanded='true']works as intended.Test plan
/patterns/menu-button/{react,vue,svelte,astro}/with PlaywrightemulateMedia({ forcedColors: 'active', colorScheme: 'dark' }):getComputedStyle(trigger, '::after')showsborderLeftColor/borderRightColor=rgba(0,0,0,0)andborderTopColor=ButtonText.transform: matrix(-1, 0, 0, -1, 0, 0)(= 180°).currentColor.npm run test:e2e:pattern --pattern=menu-buttonpasses.npm run lintpasses.🤖 Generated with Claude Code