Open
Conversation
Author
|
need the mac testing to confirm exactly what failure output is at each step for documentation |
Author
|
testing on andrea's computer, it left the fsevents uninstalled :( |
Author
|
Andrea computer running odd (maybe because conda environment) @CarlosACJ55 pls pull, ensure no package-lock.json, and run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
tailwindcss throws error messages on Mac (darwin) if "fsevents" not present, have to manual install it. but fsevents fails on non-Mac. avoid unsynced package.json by making it optional for non-Macs, hopefully this makes it install on Macs. Also, making things work off
npm installwithout needing to do manual, no-save installs is nice.Usage
just run
npm install(regardless of OS), do not need to manuallynpm -D install tailwindcssChanges
Non-trivial Files
package.json
Testing
On my Linux device, this silently skips fsevents:
We absolutely need a Mac to re-run
npm installand test these commands do install fsevents.Dependencies
fsevents made optional per OS
Documentation Changes
Issues and Bugs
If legitimate error occurs installing fsevents on mac, this may fail silently. "overrides" also might have unknown consequences
Possible Solutions
Hopefully, the tailwindcss error messages make it obvious if fsevents failed to install, at which point you can run:
npm install fsevents@^2.3.2 --no-saveAdditional Notes
As far as I know, there's no generally accepted npm method to accomplish this. Running install scripts from package.json is considered an anti-pattern; there is a package to do this
run-script-os, but we'd be pulling in a new dependency around selective install of a single dep.