Finish task#1356
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on implementing the promises! The logic for firstPromise and thirdPromise is working correctly, and you've handled the event listeners and timeouts perfectly.
However, one change is needed for secondPromise. The task requirements state that this promise must never be rejected. Your current implementation includes a reject() call. Although it's unreachable because resolve() is called first, its presence violates this core requirement.
Please remove the rejection logic from secondPromise to fully align with the task description. Once that's fixed, this will be ready for approval!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! You've successfully addressed the feedback from the previous review. The logic for all three promises is now perfectly implemented, and it's great to see that the secondPromise correctly never rejects. The code is clean, functional, and meets all task specifications. I am happy to approve your submission. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK